fix: use trait dispatch for array Packable::unpack in card_game_contract#21683
Merged
nchamo merged 1 commit intobackport-to-v4-next-stagingfrom Mar 17, 2026
Merged
Conversation
The turbofish syntax <[T; N]>::unpack(...) is not supported by Noir for calling static trait methods on array types. Use Packable::unpack(...) with type annotations instead, letting the compiler infer the correct impl from the assignment target type.
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
nchamo
approved these changes
Mar 17, 2026
AztecBot
added a commit
that referenced
this pull request
Mar 19, 2026
BEGIN_COMMIT_OVERRIDE feat: entrypoint replay protection (#21649) feat: guard BoundedVec oracle returns against dirty trailing storage (#21589) fix: add bounds when allocating arrays in deserialization (#21622) feat: implement manual Packable for structs with sub-Field members (#21576) fix(aztec-node): throw on existing nullifier in getLowNullifierMembershipWitness (#21472) fix: use trait dispatch for array Packable::unpack in card_game_contract (#21683) fix(p2p): penalize peers for errors during response reading (#21680) fix: update nullifier non-inclusion test expectations after early oracle throw (backport #21600) (#21615) fix(aztec-nr): fix OOB index with nonzero offset (#21613) fix(builder): persist contractsDB across blocks within a checkpoint (#21520) fix(stdlib): accept null return_type for void Noir functions (#21647) feat: gas estimations on send (#21646) fix(validator): process block proposals from own validator keys in HA setups (backport #21603) (#21659) fix(p2p): penalize peer on tx rejected by pool (#21677) fix(sequencer): fix checkpoint budget redistribution for multi-block slots (#21692) feat: sync cache invalidation oracle (backport #21459) (#21730) feat!: make AES128 decrypt oracle return Option (backport #21696) (#21735) feat!: include init_hash in private initialization nullifier (backport #21427) (#21736) fix(sequencer): extract gas and blob configs from valid requests only (A-677) (#21747) chore: backport #21744 — replace dead BOOTSTRAP_TO env var with bootstrap.sh build arg (#21748) refactor: revert remove assert_bounded_vec_trimmed (#21758) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure on backport PR #21654 caused by
card_game_contractcompilation error.The
<[T; N]>::unpack(...)turbofish syntax doesn't work in Noir for calling static trait methods on array types. Changed toPackable::unpack(...)with explicit type annotations, letting the compiler infer the correct impl from the assignment target.Details
game.nr:87—<[PlayerEntry; NUMBER_OF_PLAYERS]>::unpack(...)→let players: [PlayerEntry; NUMBER_OF_PLAYERS] = Packable::unpack(...)game.nr:93—<[Card; PLAYABLE_CARDS]>::unpack(...)→let rounds_cards: [Card; PLAYABLE_CARDS] = Packable::unpack(...)This was introduced in commit c6e2040 (PR #21576 "implement manual Packable for structs with sub-Field members") which was backported to v4-next.
All 8 card_game_contract tests pass after the fix.
ClaudeBox log: https://claudebox.work/s/5801e05688fc0bd3?run=1